> >I think that many people would make the same mistake when looking at the > >code. The change doesn't seem to hurt anything? > Actually, yes. But it does imporve nothing but coding style. > I think Alexander's code style make function more compact is also a > good code style. So, just keep it original. Still it makes noise when other people look at the code and find that it looks odd. Removing the false positive in smatch won't completely help, because people could look at the code for other reasons. But, as you like. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
