Dan,
Do not need to call __iommu_free_mapped_mem() for err_unlock. for
no new elements are added into __iommu_remapped_mem when drops to
err_unlock.
Thanks
Zhenhua
On 06/02/2015 10:06 PM, Dan Carpenter wrote:
On Tue, Jun 02, 2015 at 03:45:18PM +0200, Joerg Roedel wrote:
On Tue, Jun 02, 2015 at 01:09:58PM +0300, Dan Carpenter wrote:
Smatch found some error paths that don't unlock. Also we can return
-ENOMEM instead of -1 if we don't have an old root entry.
Fixes: 5908f10af4b9 ('iommu/vt-d: datatypes and functions used for kdump')
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Applied, thanks.
Releasing the lock is good, but we might need to do other error handling
as well. Presumably this function always succeeds anyway? It seems
like it might be essential for booting.
What do you mean by 'other error handling'? In error case a negative
value is returned and the caller checks that.
I was just worried we should call __iommu_free_mapped_mem() or
something. I don't know this code very well is what I'm saying...
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
