On Tue, May 19, 2015 at 05:26:21PM +0200, Wim de With wrote: > On 19-5-2015 17:20, Dan Carpenter wrote: > > On Tue, May 19, 2015 at 05:14:49PM +0200, Wim de With wrote: > >> On 19-5-2015 16:08, Dan Carpenter wrote: > >>> First of gmail always marks your emails as spam so I only see the > >>> replies. > >> > >> That might be because of my SPF/DMARC configuration. I think it's fixed now. > >> > >>> Both declaration formats are acceptable. > >>> > >>> These days instead of "substantially to the right" most people > >>> insist that they be aligned. I think checkpatch.pl --strict enforces > >>> this. > >> > >> So as long as I use the same style consistently in a source file, I'm good? > >> > > > > I'm slightly confused what you mean. If you're asking if you should > > redo the visorchipset.c patch then don't bother with that. The original > > code is fine. > > > > regards, > > dan carpenter > > Yeah, I realized that already, but I saw some other files in > drivers/staging that had lines over 80 characters long, so I just wanted > to know how to do it correctly the next time I submit a patch like that. Sure. Go for it. Even if you mess up, staging is basically a friendly place and we are used to newbies. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
