On Fri, 15 May 2015, Dan Carpenter wrote: > On Fri, May 15, 2015 at 09:06:55AM +0800, Qiao Zhou wrote: > > >>@@ -360,8 +366,14 @@ static inline int pm80x_dev_resume(struct device *dev) > > >> struct pm80x_chip *chip = dev_get_drvdata(pdev->dev.parent); > > >> int irq = platform_get_irq(pdev, 0); > > >> > > >>+ if ((irq < 0) || (irq >= 24)) { > > >>+ dev_err(dev, "pm80x: wrong irq 0x%x\n", irq); > > >>+ > > > > > >Superfluous '\n'. > > Will refine it. > > The \n is ok isn't it? It's not a blocker, but it is superfluous: git grep -A2 dev_err -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html