Re: flow_dissect: use programable dissector in skb_flow_dissect and friends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fri, May 15, 2015 at 11:54:31AM CEST, dan.carpenter@xxxxxxxxxx wrote:
>Hello Jiri Pirko,
>
>The patch 06635a35d13d: "flow_dissect: use programable dissector in
>skb_flow_dissect and friends" from May 12, 2015, leads to the
>following static checker warning:
>
>	net/core/flow_dissector.c:283 __skb_flow_dissect()
>	info: ignoring unreachable code.
>
>net/core/flow_dissector.c
>   279  
>   280                  if (skb_flow_dissector_uses_key(flow_dissector,
>   281                                                  FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS)) {
>   282                          return true;
>                                ^^^^^^^^^^^^
>   283                          key_addrs = skb_flow_dissector_target(flow_dissector,
>   284                                                                FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
>   285                                                                target_container);
>   286                          key_addrs->src = hdr->srcnode;
>   287                          key_addrs->dst = 0;
>   288                  }
>   289                  return true;
>
>regards,
>dan carpenter

Will fix that.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux