On May 14 2015 or thereabouts, Dan Carpenter wrote:
> These defines are used like this:
>
> if (test_bit(I2C_HID_STARTED, &ihid->flags))
>
> The intent was to use bits 0, 1, and 2 but because of the extra shifts
> we're using bits 1, 2, and 4. It's harmless becuase it's done
> consistently but it's not the intent and static checkers will complain.
>
> Fixes: 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Same as the other one:
Oops. Looks good to me:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Cheers,
Benjamin
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 92d6cdf..cadec6a 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -42,9 +42,9 @@
> #include <linux/i2c/i2c-hid.h>
>
> /* flags */
> -#define I2C_HID_STARTED (1 << 0)
> -#define I2C_HID_RESET_PENDING (1 << 1)
> -#define I2C_HID_READ_PENDING (1 << 2)
> +#define I2C_HID_STARTED 0
> +#define I2C_HID_RESET_PENDING 1
> +#define I2C_HID_READ_PENDING 2
>
> #define I2C_HID_PWR_ON 0x00
> #define I2C_HID_PWR_SLEEP 0x01
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
