Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > "base_irq" needs to be signed for the error handling to work. Also we > can remove the initialization because we re-assign it later. Indeed. I suppose smatch found this one with : arch/arm/mach-pxa/pxa_cplds_irqs.c:126 cplds_probe() warn: unsigned 'base_irq' is never less than zero. I still don't see which tool found the "re-assign" part ... Anyway, thanks for this, I'll queue it in pxa/fixes. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html