Re: type mismatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hm...  You're right.  I'm going to retract some things.

1) I didn't end up adding a special case handling for this, I only
   wanted to but never got around to it.

2) Also these aren't *that* common as I was thinking.  They're mostly
   limitted to emulex.

drivers/net/ethernet/emulex/benet/be_cmds.c
  3173  
  3174          be_wrb_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,
                                       ^^^^^^^^^
First element.

  3175                                 OPCODE_COMMON_SET_HSW_CONFIG, sizeof(*req), wrb,
                                                                     ^^^^^^^^^^^^
Here is the sizeof().

  3176                                 NULL);
  3177  

3) It's also obvious why emulex would do this because the req struct
   could be defined a lot of different ways so long as the first element
   is a header.  It's like a union.

Sorry for the misinformation.  My bad.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux