Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 7 May 2015, Dan Carpenter wrote:

> On Thu, May 07, 2015 at 03:36:05AM +0000, Dilger, Andreas wrote:
> > On 2015/05/06, 6:02 AM, "Mike Shuey" <shuey@xxxxxxxxxx> wrote:
> >
> > >Clean up spacing in some variable declarations, to be more consistent.
> > >
> > >It's small, but I need to start somewhere.  Please let me know if I'm not
> > >adhering to proper procedure for trivial cleanups.
> >
> > It's actually Lustre coding style to align the variable declarations.
> > Is this something that causes checkpatch.pl to complain?  If not, I'd
> > prefer not to change all of these declarations, since it causes a lot
> > of code churn for very little benefit.
>
> In theory it's nice, but in reality aligning variables doesn't work in
> .c files.  If you look at the patch, almost every declaration block uses
> higgledy piggledy alignment.

Probably the use of tabs and spaces is not consistent.

julia
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux