Re: [patch] iwlwifi: mvm: remove some dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2015-05-07 at 12:58 +0300, Dan Carpenter wrote:
> "ret" is zero here so we can remove this stray check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/net/wireless/iwlwifi/mvm/fw.c b/drivers/net/wireless/iwlwifi/mvm/fw.c
> index df86963..41f4763 100644
> --- a/drivers/net/wireless/iwlwifi/mvm/fw.c
> +++ b/drivers/net/wireless/iwlwifi/mvm/fw.c
> @@ -663,8 +663,6 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
>  		 */
>  		_iwl_trans_stop_device(mvm->trans, false);
>  		_iwl_trans_start_hw(mvm->trans, false);
> -		if (ret)
> -			return ret;

It looks like "ret = _iwl_trans_start_hw(...)" was intended though?

johannes

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux