Am 01.05.2015 21:37, schrieb Julia Lawall: > Kfree can cope with a null argument, so drop null tests. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ expression ptr; @@ > > - if (ptr != NULL) > kfree(ptr); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c b/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c > index 604e511..989cdcd 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c > @@ -384,8 +384,7 @@ struct ptlrpc_cli_ctx *plain_sec_install_ctx(struct plain_sec *plsec) > if (ctx) { > atomic_inc(&ctx->cc_refcount); > > - if (ctx_new) > - kfree(ctx_new); > + kfree(ctx_new); > } else if (ctx_new) { > ctx = ctx_new; > The error handling here is not obvious the OBD_ALLOC_PTR(ctx_new); should have something like if (!ctx_new) return NULL; just my 2 cents re, wh > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
