iommu_domain_alloc() returns NULL on error, it doesn't return error pointers. Fixes: 58fd9375c2c5 ('drm/nouveau/platform: probe IOMMU if present') Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/drivers/gpu/drm/nouveau/nouveau_platform.c b/drivers/gpu/drm/nouveau/nouveau_platform.c index 775277f..4fbd35d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_platform.c +++ b/drivers/gpu/drm/nouveau/nouveau_platform.c @@ -102,7 +102,7 @@ static void nouveau_platform_probe_iommu(struct device *dev, if (iommu_present(&platform_bus_type)) { gpu->iommu.domain = iommu_domain_alloc(&platform_bus_type); - if (IS_ERR(gpu->iommu.domain)) + if (!gpu->iommu.domain) goto error; /* -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html