Re: [patch] ext4 crypto: type bug with encrypted symlinks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nak.  ostr.len is the variable being swabbed, and it is a __u32.

Cheers, Andreas

> On Apr 15, 2015, at 03:21, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> 
> sd->len is an __le16 and not an __le32.
> 
> Fixes: f1195c72c951 ('ext4 crypto: Add symlink encryption')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 69e12ee..5c82a3c 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3256,7 +3256,7 @@ static int ext4_symlink(struct inode *dir,
>        ext4_put_fname_crypto_ctx(&ctx);
>        if (err < 0)
>            goto err_drop_inode;
> -        sd->len = cpu_to_le32(ostr.len);
> +        sd->len = cpu_to_le16(ostr.len);
>        disk_link.name = (char *) sd;
>    }
> 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux