Re: [patch] perf/x86/intel/pt: cleanup error handling in pt_pmu_hw_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> On Wed, Apr 15, 2015 at 01:10:17PM +0300, Alexander Shishkin wrote:
>> How does the following look to you?
>> 
>
> Are you sure you want to know??  :P

Why would I ask if I didn't?

> Of course, I would prefer:
>
> 	return 0;
>
> out_stop:
> 	hwc->state = PERF_HES_STOPPED;
>
> 	return ret;
>
> But your version is also fine.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux