I've looked at this some more. Most of the places which call of_property_read_u32_index() check the return code. The ones that don't mostly initialize their values going in. The remainder introduce static checker warnings like: drivers/clk/ti/divider.c:472 ti_clk_get_div_table() error: potentially using uninitialized 'val'. These warnings cause me pain. It calls of_get_property() earlier so it won't return -EINVAL. I don't know if it can return -ENODATA or -EOVERFLOW? I guess not. Honestly, I hate ambigous code like this. If it were just a clear bug then I could fix it but I invest more time in ambiguous code and end up not writing a patch. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
