On Fri, Apr 10, 2015 at 11:30:41AM +0300, Dan Carpenter wrote:
> Static checkers complain that "timers[i].delay_on" is an unsigned long
> but we're writing to only 32 bits of it. The code works on 32 bit
> systems and little endian 64 bit systems so it doesn't cause a problem
> in practise but it's still better to silence the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Simon Guinot <simon.guinot@xxxxxxxxxxxx>
Note that your patch applies on the top of a patch "leds: netxbig: add
device tree binding" which has not been merged yet by Bryan. For now,
this patch only sits in the mvebu/for-next branch for testing purpose.
And it is still not clear to me in which tree the patch will go. That's
why I think you should resend your patch to the mvebu maintainers (added
in Cc) on the LAKML. Probably they will be interested in merging your
clean-up patch in the mvebu/for-next branch as well.
Regards,
Simon
> ---
> v2: use a temporary variable
>
> diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
> index 028686f2..6cb4537 100644
> --- a/drivers/leds/leds-netxbig.c
> +++ b/drivers/leds/leds-netxbig.c
> @@ -444,12 +444,17 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
> if (!timers)
> return -ENOMEM;
> for (i = 0; i < num_timers; i++) {
> + u32 delay_on = 0;
> + u32 delay_off = 0;
> +
> of_property_read_u32_index(np, "timers", 3 * i,
> &timers[i].mode);
> of_property_read_u32_index(np, "timers", 3 * i + 1,
> - (u32 *) &timers[i].delay_on);
> + &delay_on);
> of_property_read_u32_index(np, "timers", 3 * i + 2,
> - (u32 *) &timers[i].delay_off);
> + &delay_off);
> + timers[i].delay_on = delay_on;
> + timers[i].delay_off = delay_off;
> }
> pdata->timer = timers;
> pdata->num_timer = num_timers;
Attachment:
signature.asc
Description: Digital signature
