Julia, yes this is a bug that we have already fixed in the latest Lustre. Sorry we haven¹t submitted this patch to kernel on time. Thanks Liang On 4/5/15, 8:06 PM, "Julia Lawall" <Julia.Lawall@xxxxxxx> wrote: >Return a negative error code on failure. > >A simplified version of the semantic match that finds this problem is as >follows: (http://coccinelle.lip6.fr/) > >// <smpl> >@@ >identifier ret; expression e1,e2; >@@ >( >if (\(ret < 0\|ret != 0\)) > { ... return ret; } >| >ret = 0 >) >... when != ret = e1 > when != &ret >*if(...) >{ > ... when != ret = e2 > when forall > return ret; >} >// </smpl> > >Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > >--- > drivers/staging/lustre/lnet/lnet/api-ni.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c >b/drivers/staging/lustre/lnet/lnet/api-ni.c >index faceb95..4a14e51 100644 >--- a/drivers/staging/lustre/lnet/lnet/api-ni.c >+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c >@@ -650,15 +650,19 @@ lnet_prepare(lnet_pid_t requested_pid) > > recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES, > sizeof(lnet_me_t)); >- if (recs == NULL) >+ if (recs == NULL) { >+ rc = -ENOMEM; > goto failed; >+ } > > the_lnet.ln_me_containers = recs; > > recs = lnet_res_containers_create(LNET_COOKIE_TYPE_MD, LNET_FL_MAX_MDS, > sizeof(lnet_libmd_t)); >- if (recs == NULL) >+ if (recs == NULL) { >+ rc = -ENOMEM; > goto failed; >+ } > > the_lnet.ln_md_containers = recs; > > >_______________________________________________ >HPDD-discuss mailing list >HPDD-discuss@xxxxxxxxxxxx >https://lists.01.org/mailman/listinfo/hpdd-discuss -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
