On Wed, Mar 11, 2015, at 06:34, Dan Carpenter wrote: > This needs to be signed for the error handling to work. Valid modes are > small positive integers. > > Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs attr') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 56eaddc..024861d 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -2938,7 +2938,7 @@ static ssize_t adaptive_kbd_mode_show(struct device > *dev, > struct device_attribute *attr, > char *buf) > { > - u32 current_mode; > + int current_mode; > > current_mode = adaptive_keyboard_get_mode(); > if (current_mode < 0) > @@ -3621,7 +3621,7 @@ static int adaptive_keyboard_get_next_mode(int > mode) > > static bool adaptive_keyboard_hotkey_notify_hotkey(unsigned int > scancode) > { > - u32 current_mode = 0; > + int current_mode = 0; > int new_mode = 0; > int keycode; > Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html