On Wed, Feb 11, 2015 at 02:21:19PM +0100, Christoph Hellwig wrote: > On Wed, Feb 11, 2015 at 04:08:32PM +0300, Dan Carpenter wrote: > > We're supposed to be testing that the fh_fsid's match but because the > > parenthesis are in the wrong place, then we only check the first > > byte. > > > > Fixes: 9558f2500a20 ('nfsd: add fh_fsid_match helper') > > Thanks, this looks good. Is there an easy to setup way to check for > these sorts of errors? This is a Smatch check I wrote a couple years ago but it never found any bugs until now so I didn't commit it. I have done. I'll push it out later and Fengguang will eventually add it to the zero day tester bot. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html