> 1) People gloss over initializers without reading them. I would find such a habit strange. > You shouldn't put complicated code in initializers. Does the affected memory allocation fall into such a category? > 2) It means you have to put a line of separation between the allocation > and the NULL check, but they should be next to each other. Would you like to extend the Linux coding style documentation? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html