From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Thu, 5 Feb 2015 11:00:42 +0300 > There are a couple bugs with the error handling in this function. > > 1) If we can't allocate "rx_ring->rx_skbuff" then we should call > dma_free_coherent() but we don't. > 2) free_rx_ring() frees "rx_ring->rx_skbuff_dma" and "rx_ring->rx_skbuff" > so calling it in a loop causes a double free. > > Also it was a bit confusing how we sometimes freed things before doing > the goto. I've cleaned it up so it does error handling in normal kernel > style. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Looks good, applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
