>> The functions clk_enable() and clk_disable() test whether their argument >> is NULL and then return immediately. > > This isn't true for clk_enable(). I stumble on an interesting name space issue once more. > It's frustrating that you make the same mistake over and over > and you are fine with doing that. I admit that there can be also risks with my update suggestions in similar ways to contributions from other software developers. A specific function implementation exists which performs also input parameter validation. http://lxr.free-electrons.com/source/drivers/sh/clk/core.c#L291 Such variants might not fit to the functions au1100fb_drv_suspend() and au1100fb_drv_resume(). Do you want that I send a reduced patch? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html