Re: [PATCH 2/2] sata_mv: More error handling for phy_power_off() in mv_platform_remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 03, 2015 at 01:32:10PM +0100, walter harms wrote:
> maybe this can be changed into
>   (void) phy_power_off(hpriv->port_phys[port]);
> 
> that would tell the compiler and other readers that this is intentional.

That's too anal to be helpful and too spurious to become even remotely
consistent.  Things like that are actualy harmful.  Note that we have
an annotation marking the other way - __must_check.  Balance is to be
found towards that direction, not this, so please stop.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux