On Sat, Jan 31, 2015 at 4:34 PM, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Sat, 31 Jan 2015 19:09:50 +0100 > > The cipso_v4_doi_putdef() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > net/netlabel/netlabel_mgmt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx> > diff --git a/net/netlabel/netlabel_mgmt.c b/net/netlabel/netlabel_mgmt.c > index 8b3b789..f5807f5 100644 > --- a/net/netlabel/netlabel_mgmt.c > +++ b/net/netlabel/netlabel_mgmt.c > @@ -242,8 +242,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info, > return 0; > > add_failure: > - if (cipsov4) > - cipso_v4_doi_putdef(cipsov4); > + cipso_v4_doi_putdef(cipsov4); > if (entry) > kfree(entry->domain); > kfree(addrmap); > -- > 2.2.2 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
