>> +exit: >> return err; >> } > > Why do you use that exit label if it does nothing more than returning > the error value? Also if nla_parse fails you dont use it but return the > error directly. While using a label which is used only to return an > error may be a matter of taste, its at least inconsistent to do both in > a function, use such a label in one case and return immediately in > another, isnt it? I find that all these cases correspond to the current Linux coding style documentation, doesn't it? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
