On 1/30/15, 2:50 AM, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> wrote:
>On Fri, Jan 30, 2015 at 11:41:27AM +0300, Dan Carpenter wrote:
>> Static checkers complain that the shifts in "(vid << 4) >> 4" perfectly
>> cancel each other out and the code is a no-op. "vid" is a u16. The
>> comment says that the intention here is to drop the upper bits so I have
>> added a cast to "u16" to do that.
>>
>> Fixes: 401b5383c6c9 ('fm10k: Add support for configuring PF interface')
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
>Oh... Rasmus Villemoes already fixed this.
>
>regards,
>dan carpenter
Yep, we have a patch coming through Jeff's tree now to resolve the issue
(technically my version of the patch, which doesn't try to mask off the
bits but instead rejects an out-of-bounds VLAN ID). Thanks, Dan!
Cheers,
Matthew
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
