On Fri, Jan 30, 2015 at 09:34:01AM +0100, Lars-Peter Clausen wrote: > On 01/30/2015 09:30 AM, Dan Carpenter wrote: > >Because of C's type promotion rules, the code shifts in > >"((val16 & 0xFFF) << 4) >> 4;" cancel each other out and they're a > >no-op. > > > >The intention here was to sign-extend then 11th bit so we can use the > >sign_extend32() function. > > > >Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > >--- > >Please review this carefully. I'm pretty sure it's correct but this is > >the first time I've ever used the sign_extend32() function. > > Hi, > > Rasmus already fixed this a couple of days ago. > > Thanks, > - Lars Oh. Good. I was CC'd on the other one that he fixed so I went looking for other bugs and I found this one. Rasmus, are you using a static checker? Which one? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
