re: csiostor:T5 Firmware fix and cleanup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Praveen Madhavan,

The patch 216ce69c7ff5: "csiostor:T5 Firmware fix and cleanup." from
Jan 27, 2015, leads to the following static checker warning:

	drivers/scsi/csiostor/csio_hw.c:1780 csio_hw_use_fwconfig()
	warn: missing error code here? 'csio_hw_validate_caps()' failed.

drivers/scsi/csiostor/csio_hw.c
  1776          }
  1777  
  1778          /* Validate device capabilities */
  1779          if (csio_hw_validate_caps(hw, mbp))

We should probably preserve the error code here instead of returning
success.

  1780                  goto bye;
  1781          /*

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux