On 01/28/2015 01:42 AM, Dan Carpenter wrote:
> If hashtab_create() returns a NULL pointer then we should return -ENOMEM
> but instead the current code returns success.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Stephen Smalley <sds@xxxxxxxxxxxxx>
>
> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index bc2a586..74aa224 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -289,12 +289,16 @@ static int policydb_init(struct policydb *p)
> goto out;
>
> p->filename_trans = hashtab_create(filenametr_hash, filenametr_cmp, (1 << 10));
> - if (!p->filename_trans)
> + if (!p->filename_trans) {
> + rc = -ENOMEM;
> goto out;
> + }
>
> p->range_tr = hashtab_create(rangetr_hash, rangetr_cmp, 256);
> - if (!p->range_tr)
> + if (!p->range_tr) {
> + rc = -ENOMEM;
> goto out;
> + }
>
> ebitmap_init(&p->filename_trans_ttypes);
> ebitmap_init(&p->policycaps);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
