Hi Dan, Thank you for the patch. On Thursday 15 January 2015 00:02:18 Dan Carpenter wrote: > "num" is a u32 so "(num > 0xFFFFFFFF)" is never true. Also the range > is already checked in kstrtou32(). > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > diff --git a/drivers/usb/gadget/function/uvc_configfs.c > b/drivers/usb/gadget/function/uvc_configfs.c index 2bd0688..738d68f 100644 > --- a/drivers/usb/gadget/function/uvc_configfs.c > +++ b/drivers/usb/gadget/function/uvc_configfs.c > @@ -1156,8 +1156,6 @@ static inline int __uvcg_fill_frm_intrv(char *buf, > void *priv) ret = kstrtou32(buf, 0, &num); > if (ret) > return ret; > - if (num > 0xFFFFFFFF) > - return -EINVAL; > > interv = priv; > **interv = cpu_to_le32(num); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
