On Saturday, December 27, 2014 2:27 AM, Dan Carpenter wrote:
>
> ARRAY_SIZE(cea_modes) is 64 so the "idx > 63" test earlier means this
Good.
'cea_modes' is defined as below. So, ARRAY_SIZE(cea_modes) is 64.
extern const struct fb_videomode cea_modes[64];
> test is really a no-op. But it's still off by one and upsets the static
> checkers so we may as well correct it.
'idx' should be 0~63, because cea_modes array is defined as 'cea_modes[64]'.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Best regards,
Jingoo Han
>
> diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
> index 5b0e313..3030269 100644
> --- a/drivers/video/fbdev/core/fbmon.c
> +++ b/drivers/video/fbdev/core/fbmon.c
> @@ -1061,7 +1061,7 @@ void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs)
> int idx = svd[i - specs->modedb_len - num];
> if (!idx || idx > 63) {
> pr_warning("Reserved SVD code %d\n", idx);
> - } else if (idx > ARRAY_SIZE(cea_modes) || !cea_modes[idx].xres) {
> + } else if (idx >= ARRAY_SIZE(cea_modes) || !cea_modes[idx].xres) {
> pr_warning("Unimplemented SVD code %d\n", idx);
> } else {
> memcpy(&m[i], cea_modes + idx, sizeof(m[i]));
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
