Hi Dan, On 17 December 2014 at 13:56, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Wed, Dec 17, 2014 at 11:46:09AM -0500, Ashwin Chaugule wrote: >> > Also this file has some Sparse warnings: >> >> I've looked at these previously too and I believe they're false >> positives. Will send a follow up patch at the earliest. >> > > They're not bugs, it just means that there are some __iomem annotations > missing and some functions should be made static or declared in a .h > file or whatever. True. We've been testing this driver on a non X86 platform in the past few days and had to make a few modifications which make some of these changes go away. Will send out a patch after some more testing. Very much appreciate your review! Cheers, Ashwin -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
