Re: [patch] phy: miphy28lp: unlock on error in miphy28lp_init()

[Gabriel Fernandez <gabriel.fernandez@xxxxxx>]

Acked-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxx>


Thanks Dan !


Best Regards

Gabriel

On 12/17/2014 12:55 AM, Dan Carpenter wrote:
> We need to unlock before returning the -EINVAL here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
> index e34da13..27fa62c 100644
> --- a/drivers/phy/phy-miphy28lp.c
> +++ b/drivers/phy/phy-miphy28lp.c
> @@ -1050,7 +1050,8 @@ static int miphy28lp_init(struct phy *phy)
>   		ret = miphy28lp_init_usb3(miphy_phy);
>   		break;
>   	default:
> -		return -EINVAL;
> +		ret = -EINVAL;
> +		break;
>   	}
>   
>   	mutex_unlock(&miphy_dev->miphy_mutex);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html