On Wed, Dec 17, 2014 at 5:25 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> There was a left over return here so the error handling isn't run.
> It leads to a small memory leak and a static checker warning.
>
> drivers/thermal/cpu_cooling.c:351 __cpufreq_cooling_register()
> info: ignoring unreachable code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Fixes: f6859014c7e7 ("thermal: cpu_cooling: Store frequencies in
descending order")
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 051eb48..9b45f64 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -347,7 +347,6 @@ __cpufreq_cooling_register(struct device_node *np,
> cpufreq_dev->freq_table = kmalloc(sizeof(*cpufreq_dev->freq_table) *
> cpufreq_dev->max_level, GFP_KERNEL);
> if (!cpufreq_dev->freq_table) {
> - return ERR_PTR(-ENOMEM);
> cool_dev = ERR_PTR(-ENOMEM);
> goto free_cdev;
> }
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
