Re: [PATCH] checkpatch: allow uppercase logging function names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe, 

Thanks for taking a look at this. Do you think I should look into
fixing the casing of these functions instead? Some of these functions
look like they're being called in a lot of places. TP_printk, for
example, is getting called over 1000 times according to git grep. 

Wesley Wiser

On Wed, 2014-12-03 at 18:47 -0800, Joe Perches wrote:
> I'm not sure that these should be encouraged.
> I'd prefer to make these lower case instead.
> 
> The regex also allows mixed case like Tp_printk.
> 
> Maybe if it was something like
> (?:[a-z0-9]+_|[A-Z0-9]+_){1,2}
> 
> but it still seems undesirable.


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux