Re: [PATCH 1/2] staging: android: ion: Deletion of unnecessary checks before two function calls

Thierry Reding <thierry.reding@xxxxxxxxx> · Tue, 2 Dec 2014 10:59:22 +0100



On Sun, Nov 23, 2014 at 07:39:23PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 23 Nov 2014 18:48:15 +0100
> 
> The functions ion_heap_destroy() and vfree() perform also input
> parameter validation. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/android/ion/ion.c              | 6 ++----
>  drivers/staging/android/ion/ion_dummy_driver.c | 6 ++----
>  drivers/staging/android/ion/tegra/tegra_ion.c  | 6 ++----
>  3 files changed, 6 insertions(+), 12 deletions(-)

Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
pgpgokQtn0KFI.pgp

Description: PGP signature