From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Mon, 1 Dec 2014 18:15:46 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/block/skd_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 1e46eb2..c4b0259 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev) return 0; msix_out: - if (entries) - kfree(entries); + kfree(entries); skd_release_msix(skdev); return rc; } -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html