Re: [patch] amdkfd: delete some dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/25/2014 06:43 PM, Dan Carpenter wrote:
> This is dead code.  We don't need to unbind here, we can just return
> directly.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@xxxxxxx>
And applied to my 3.19-next-wip tree.
Thanks!

    Oded

> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index a17e2dd..b4f49ac 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -348,11 +348,6 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
>  	if (err < 0)
>  		return ERR_PTR(err);
>  
> -	if (err < 0) {
> -		amd_iommu_unbind_pasid(dev->pdev, p->pasid);
> -		return ERR_PTR(err);
> -	}
> -
>  	pdd->bound = true;
>  
>  	return pdd;
> 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux