Hi Markus, Le lundi 24 novembre 2014, 20:40:22 SF Markus Elfring a écrit : > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Mon, 24 Nov 2014 20:30:29 +0100 > > The backlight_device_unregister() function tests whether its argument is > NULL and then returns immediately. Thus the test around the call is not > needed. > > This issue was detected by using the Coccinelle software. What script was used ? Is it in scripts/coccinelle ? > diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c > index 70222f2..6d2bac0 100644 > --- a/drivers/platform/x86/msi-wmi.c > +++ b/drivers/platform/x86/msi-wmi.c > @@ -354,8 +354,7 @@ static void __exit msi_wmi_exit(void) > sparse_keymap_free(msi_wmi_input_dev); > input_unregister_device(msi_wmi_input_dev); > } > - if (backlight) > - backlight_device_unregister(backlight); > + backlight_device_unregister(backlight); > } > > module_init(msi_wmi_init); For this part: Acked-by: Anisse Astier <anisse@xxxxxxxxx> Regards, Anisse -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
