On 11/18, Dan Carpenter wrote:
>
> Smatch complains about this:
>
> kernel/exit.c:543 forget_original_parent()
> warn: add some parenthesis here?
>
> I don't normally advocate changing the code to make the static checker
> happy but these are normally precedence bugs so I think it's ok to put
> parenthesis so it's clear the code is deliberate.
I still think that "if (!A == B)" doesn't look as a potential precedence
bug, but I won't argue.
Andrew, this fixes exit-reparent-cleanup-the-changing-of-parent.patch
in -mm tree.
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/kernel/exit.c b/kernel/exit.c
> index 6192422..1192d12 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -540,7 +540,7 @@ static void forget_original_parent(struct task_struct *father)
> list_for_each_entry(p, &father->children, sibling) {
> for_each_thread(p, t) {
> t->real_parent = reaper;
> - BUG_ON(!t->ptrace != (t->parent == father));
> + BUG_ON((!t->ptrace) != (t->parent == father));
> if (likely(!t->ptrace))
> t->parent = t->real_parent;
> if (t->pdeath_signal)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
