Em Tue, 11 Nov 2014 17:55:09 +0100 Borislav Petkov <bp@xxxxxxxxx> escreveu: > Did this one get missed? Mauro? Yeah, I missed that, sorry. I can apply it on my tree, but if you want to apply on yours, feel free to do it, and add my ack: Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > On Fri, Aug 01, 2014 at 11:25:14AM +0300, Dan Carpenter wrote: > > My static checker complains because the "e->location" has up to 256 > > characters but we are copying it into the "pvt->detail_location" which > > only has space for 240 characters. That's not counting the surrounding > > text and the "e->other_detail" string which can be over 80 characters > > long. > > > > I am not familiar with this code but presumably it normally works. > > Let's add a limit though for safety. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > > index 8399b4e..b246819 100644 > > --- a/drivers/edac/ghes_edac.c > > +++ b/drivers/edac/ghes_edac.c > > @@ -413,8 +413,8 @@ void ghes_edac_report_mem_error(struct ghes *ghes, int sev, > > > > /* Generate the trace event */ > > grain_bits = fls_long(e->grain); > > - sprintf(pvt->detail_location, "APEI location: %s %s", > > - e->location, e->other_detail); > > + snprintf(pvt->detail_location, sizeof(pvt->detail_location), > > + "APEI location: %s %s", e->location, e->other_detail); > > trace_mc_event(type, e->msg, e->label, e->error_count, > > mci->mc_idx, e->top_layer, e->mid_layer, e->low_layer, > > PAGES_TO_MiB(e->page_frame_number) | e->offset_in_page, > > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
