On Thu, Oct 16, 2014 at 04:57:07PM +0300, Stanimir Varbanov wrote: > > @@ -100,6 +101,7 @@ static int pm8xxx_rtc_set_time(struct device *dev, struct rtc_time *tm) > > dev_dbg(dev, "Seconds value to be written to RTC = %lu\n", secs); > > > > spin_lock_irqsave(&rtc_dd->ctrl_reg_lock, irq_flags); > > + locked = 1; > > Sparse complaining in this function too: > > warning: context imbalance in 'pm8xxx_rtc_set_time' - different lock > contexts for basic block Yeah. Smatch is a little more clever than Sparse this time. :) Smatch accepted any fix but Sparse complained regardless. > > I'm wondering for a better fix to this. Isn't better to avoid this > conditional call to spin_unlock_irqrestore() and lock regmap writes > every time without care is the alarm is enabled or not. > I don't know. If you go that road, please give me a Reporte-by tag. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
