Re: [patch] checkpatch: remove the ether_addr_copy warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-10-03 at 12:35 +0300, Dan Carpenter wrote:
> Most people sending checkpatch.pl fixes don't know how to verify the
> alignment.  This checkpatch warning just encourages newbies to try
> introduce bugs.  Patch submitters tell us that they just sed the code
> and it's the job for the maintainer to check that it's correct.

I haven't seen many instances of bad patch submittals
on netdev.  Is this mostly an issue for staging?

Maybe a downgrade to CHK requiring --strict is OK.

> If you want to work on these then you can get the same information by
> typing `grep -nw memcpy drivers/net/ -R | grep ETH_ALEN`

That's not much of an argument for or against anything in
checkpatch as every operation done by it can be reproduced
by a series of grep operations.


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux