>>> If you are convinced that dropping the null tests is a good idea, then you >>> can submit the patch that makes the change to the relevant maintainers and >>> mailing lists. >From 48c9c4f61a7d7ea98538e02631a981a429281005 Mon Sep 17 00:00:00 2001 From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Wed, 5 Mar 2014 18:15:34 +0100 Subject: [PATCH 1/5] Addition of a semantic patch file for showing unnecessary checks before a few known functions This semantic patch pattern tries to find source code places where a check is performed for an expression that is passed to a function (like "kfree") which checks this single parameter itself for usability. Redundant value or pointer checks can be avoided here. The pattern contains a special comment in a regular expression for a SmPL constraint which supports extensions. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- .../deletions/delete_unnecessary_checks_template1.cocci | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 scripts/coccinelle/deletions/delete_unnecessary_checks_template1.cocci diff --git a/scripts/coccinelle/deletions/delete_unnecessary_checks_template1.cocci b/scripts/coccinelle/deletions/delete_unnecessary_checks_template1.cocci new file mode 100644 index 0000000..b092051 --- /dev/null +++ b/scripts/coccinelle/deletions/delete_unnecessary_checks_template1.cocci @@ -0,0 +1,13 @@ +@Delete_unnecessary_checks@ +expression x; +identifier release =~ "^(?x) +(?: + (?:kz?|slob_)free +| + (?: +# Alternation placeholder + ) +)$"; +@@ +-if (x) + release(x); -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
