On Sat, Aug 23, 2014 at 05:32:37PM +0200, Julia Lawall wrote: > > > > The closing brace should be in column 0 of the next line. Also, the > > final field initializer should have a comma after it. (Likewise for the > > remaining changes in this file.) > > In general, I haven't changed the presence or absence of trailing commas. > Should I add them everywhere? Probably, yeah. Trailing commas are better. It's not worth resending, but the script should add them I think. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html