On Fri, Aug 08, 2014 at 03:56:02PM +0200, Benoit Taine wrote: > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. > > A simplified version of the semantic patch that makes this change is as > follows (http://coccinelle.lip6.fr/): > > // <smpl> > > @@ > identifier i; > declarer name DEFINE_PCI_DEVICE_TABLE; > initializer z; > @@ > > - DEFINE_PCI_DEVICE_TABLE(i) > + const struct pci_device_id i[] > = z; > > // </smpl> > > I previously sent parts of this patch to check wether or not it was > worth sending, and Bjorn answered: > > Benoit, how about if you wait until about half-way through the merge > > window after v3.16 releases, generate an up-to-date single patch, and > > post that? Then we can try to get it in before v3.17-rc1 to minimize > > merge hassles. > > So here it is, based on linux-next on 2014-08-07. Applied to my for-linus branch for v3.17, thanks! Bjorn -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
