Re: [patch 119/197] scripts/coccinelle/free: Delete NULL test before freeing functions?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I still don't think this should be done for any random function that 
> performs a null test on its argument.  The corrections involved here are 
> not as trivial as they would seem.

I would prefer to make the list of corresponding function names more complete.


> Often it is not the case that the null test at the call site should be
> just deleted, instead the code should be reorganized.

Which source code places do you know where a different approach might look better?


> (Personally, I don't like the whole null test removal idea. [...]

Would you like to clarify involved software concerns a bit more?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux