On Thu, 7 Aug 2014 14:49:06 +0200 Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > > diff --git a/drivers/atm/atmtcp.c b/drivers/atm/atmtcp.c > index 0e3f8f9..c8e4fb4 100644 > --- a/drivers/atm/atmtcp.c > +++ b/drivers/atm/atmtcp.c > @@ -299,6 +299,7 @@ static int atmtcp_c_send(struct atm_vcc *vcc,struct sk_buff *skb) > out_vcc = find_vcc(dev, ntohs(hdr->vpi), ntohs(hdr->vci)); > read_unlock(&vcc_sklist_lock); > if (!out_vcc) { > + result = -ESRCH; This should probably be -EUNATCH to match the rest of the code. > atomic_inc(&vcc->stats->tx_err); > goto done; > } > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
