Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 08/02/2014 05:46 PM, Joe Perches wrote:
On Sat, 2014-08-02 at 15:20 -0700, Hans Wennborg wrote:
Signed-off-by: Hans Wennborg <hans@xxxxxxxxxx>
---
  arch/cris/arch-v32/drivers/cryptocop.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
[]
@@ -3155,7 +3155,7 @@ static void print_dma_descriptors(struct cryptocop_int_operation *iop)
  	printk("print_dma_descriptors start\n");

  	printk("iop:\n");
-	printk("\tsid: 0x%lld\n", iop->sid);
+	printk("\tsid: 0x%llx\n", iop->sid);

  	printk("\tcdesc_out: 0x%p\n", iop->cdesc_out);
  	printk("\tcdesc_in: 0x%p\n", iop->cdesc_in);

Thanks.

This is a surprisingly common error:

$ /usr/bin/git grep -P '0x\%(?!ull\b|ul\b|u\b|lu\b|llu\b|llux\b|lux\b|lx\b|lluX\b|luX\b|lX\b)[ul]*[ud]'
[...]

Yes, I have a patch for a bunch of these, but I figured it would be easier to get it merged if I split it up. (Complete kernel newbie here.)

 - Hans
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux