Bitwise AND was intended here obviously. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- Static analysis. I wasn't able to compile this. Also lustre needs an entry in MAINTAINERS because otherwise get_maintainer.pl still sends everything to Peng Tao only. diff --git a/drivers/staging/lustre/lustre/obdecho/echo.c b/drivers/staging/lustre/lustre/obdecho/echo.c index f3b7429..dae1599 100644 --- a/drivers/staging/lustre/lustre/obdecho/echo.c +++ b/drivers/staging/lustre/lustre/obdecho/echo.c @@ -125,7 +125,7 @@ static int echo_create(const struct lu_env *env, struct obd_export *exp, return -EINVAL; } - if (!(oa->o_mode && S_IFMT)) { + if (!(oa->o_mode & S_IFMT)) { CERROR("echo obd: no type!\n"); return -ENOENT; } -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html